-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix errors in new templates #420
Fix errors in new templates #420
Conversation
Install containerd.io instead of containerd Add quotes around the kubernetes pause image Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cprivitere The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
/honk |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/joke |
@cprivitere: Why do mathematicians hate the U.S.? Because it's indivisible. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Removed things that were required and had no defaults Added a variable for CPEM verison Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
07d5e47
to
f29d64a
Compare
Move the commands to run on all control plane nodes Remove unnecessary KUBECONFIG export to save a line Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
Move the kube-vip manifest setup to after kubeadm is run, this avoids a situation where kube-vip fights with previous control plane nodes before they've joined the cluster. Move the crictl/kubectl commands to run on all control plane nodes Remove unnecessary KUBECONFIG export to save a line Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
…all_script Update go install script and add kustomize install script
Install containerd.io instead of containerd Add quotes around the kubernetes pause image Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
Removed things that were required and had no defaults Added a variable for CPEM verison Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
Move the commands to run on all control plane nodes Remove unnecessary KUBECONFIG export to save a line Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
Move the kube-vip manifest setup to after kubeadm is run, this avoids a situation where kube-vip fights with previous control plane nodes before they've joined the cluster. Move the crictl/kubectl commands to run on all control plane nodes Remove unnecessary KUBECONFIG export to save a line Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
…luster-api-provider-packet into cprivitere/issue419
Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
/lgtm |
Remove docker.io from apt-get remove line
Install containerd.io instead of containerd
Add quotes around the kubernetes pause image
Signed-off-by: Chris Privitere 23177737+cprivitere@users.noreply.github.com
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #419